[JENKINS-21248] shallow submodule update #344
Conversation
* in case the used git does not support shallow submodules, just
log a warning instead of throwing an exception
* Javadoc texts are used from the already existing CloneCommand
* tests are running fine now and cover more cases
* file:// has to be used as protocol for local remotes,
otherwise git doesn't perform shallow cloning
* a local repository has to be used for shallow clone testing,
because GitHub doesn't allow fetching dedicated commits
* see isaacs/github#436
* this would result in the following
error: Server does not allow request for unadvertised object
* other minor improvements
darxriggs
force-pushed
the
shallow-submodule-update
branch
from
9ca33ca
to
b3f7b6b
Compare
|
@MarkEWaite Which version do you plan to release this with? I want to prepare a pull request for @fujii's update on the git-plugin (fujii/git-plugin@035090e) plus a minor change on it. |
|
It will be released in git client plugin 3.0.0. The matching change needs to be made in git plugin 4.0.0. I think we'll want at least one more beta release of both of them. There are some changes from git plugin changes from @jacob-keller that need to be reviewed and hopefully merged into the git plugin 4.0.0 before the next beta release. |
|
@MarkEWaite just let me know when you prepared a new beta release of the git-client-plugin containing this change, so I can prepare the pull request in git-plugin using it. |
|
Git client plugin 3.0.0-beta5 has released and includes this change. You can also use an incrementals version if you need access to a build that is not yet delivered as a beta. |
darxriggs
changed the title
This implements https://issues.jenkins-ci.org/browse/JENKINS-21248.
The original implementation is by @fujii - see pull request #303.
I rebased his commit 89ba2d3 on master (without changes) and added improvements via new commits.
The tests are working fine now with a locally created git repository containing a submodule.